Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for importanize on Windows #32

Merged
merged 6 commits into from
Jul 28, 2015
Merged

Fix for importanize on Windows #32

merged 6 commits into from
Jul 28, 2015

Conversation

miki725
Copy link
Owner

@miki725 miki725 commented Jul 17, 2015

@xsaero00 can you please verify that this works for you

closes #29

@xsaero00
Copy link

The fix seems to be working.

Installed directly from this branch
pip install git+https://github.com/miki725/importanize.git@windows --upgrade
Env:

flake8==2.4.0
future==0.15.0
importanize==0.4
ipython==2.3.1
mccabe==0.3
pep8==1.5.7
pyflakes==0.8.1
pyreadline==2.0
six==1.9.0
virtualenv==1.9.1
virtualenvwrapper-win==1.1.5

The output of command on Linux is the same as the one on Windows.

@miki725
Copy link
Owner Author

miki725 commented Jul 27, 2015

@xsaero00 👍 thank you for confirming!

@xsaero00
Copy link

No problem.

miki725 added a commit that referenced this pull request Jul 28, 2015
@miki725
Merge pull request #32 from miki725/windows
0fc5b5f 
Fix for importanize on Windows
@miki725 miki725 merged commit 0fc5b5f into master Jul 28, 2015
@miki725 miki725 deleted the windows branch July 28, 2015 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importanize produces different results when run on Windows vs Linux
2 participants
@miki725 @xsaero00